Skip to content

Don't assume repl input is only 2 statements #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Nov 9, 2019

fix #7529

each statement in repl input that contains a def annotated with @main generates a new typedef that appears after the typedef containing the repl input

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests for that?

@bishabosha
Copy link
Member Author

I've checked and there are no tests or framework for :load, but I'll add one

@nicolasstucki
Copy link
Contributor

@bishabosha could you make the commit message start with Fix #7529: Don't ...

@bishabosha
Copy link
Member Author

I've adjusted the commit message

Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@nicolasstucki nicolasstucki merged commit bc87529 into scala:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOTR Crashes on @main
3 participants